docs: add pull request templates#223
Open
gbartolini wants to merge 2 commits into
Open
Conversation
mnencia
approved these changes
May 29, 2026
gbartolini
force-pushed
the
docs/pr-templates
branch
from
8ef5237 to
1945148
Compare
NiccoloFei
force-pushed
the
docs/pr-templates
branch
from
1945148 to
48905d2
Compare
Add two GitHub PR templates with contributor and maintainer checklists: - new_extension.md: full lifecycle checklist for adding a new extension (proposal link, package verification, scaffolding, metadata/renovate/license gates, E2E, README, CODEOWNERS and maintenance commitment). - default.md: lighter checklist for version bumps, fixes, shared tooling and documentation changes; applied automatically by GitHub. Reference both templates from the "Commit and Submit" section of CONTRIBUTING_NEW_EXTENSION.md, since GitHub does not show a PR template chooser. Assisted-by: Claude Opus 4.8 Signed-off-by: Gabriele Bartolini <gabriele.bartolini@enterprisedb.com>
Signed-off-by: Marco Nenciarini <marco.nenciarini@enterprisedb.com>
NiccoloFei
force-pushed
the
docs/pr-templates
branch
from
48905d2 to
0d1dc57
Compare
GabriFedi97
reviewed
Jun 3, 2026
| - [ ] Every component in the image is covered by a license on the | ||
| [CNCF Allowlist](https://github.com/cncf/foundation/blob/main/policies-guidance/allowed-third-party-license-policy.md); | ||
| SPDX `licenses` in `metadata.hcl` are accurate. | ||
| - [ ] `task checks:all` passes locally. |
Contributor
There was a problem hiding this comment.
Is this really required? It performs a local docker buildx bake --check for all the extensions
Contributor
Author
There was a problem hiding this comment.
That is what CONTRIBUTING_NEW_EXTENSION.md says, though.
Contributor
There was a problem hiding this comment.
Well, I think that's fine to be there as we are informing how to do local testing (even if it should just target the extension being proposed and not all), but once the PR is opened we probably should just rely on CI results.
GabriFedi97
reviewed
Jun 3, 2026
| [CNCF Allowlist](https://github.com/cncf/foundation/blob/main/policies-guidance/allowed-third-party-license-policy.md); | ||
| SPDX `licenses` in `metadata.hcl` are accurate. | ||
| - [ ] `task checks:all` passes locally. | ||
| - [ ] Full E2E passes: `task e2e:test:full TARGET="<extension-name>"`. |
Contributor
There was a problem hiding this comment.
This is already covered by the CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds GitHub pull request templates with contributor and maintainer checklists, derived from the lifecycle documented in
CONTRIBUTING_NEW_EXTENSION.md.Two templates live under
.github/PULL_REQUEST_TEMPLATE/:new_extension.md— full lifecycle checklist for adding a new extension: proposal link, package verification ontrixie/bookworm, scaffolding,metadata.hcl/renovate/license gates, E2E, README examples,CODEOWNERSentry, and the maintenance commitment — plus a maintainer merge checklist (CI matrix, DCO, license compliance,Dockerfile/metadata.hclreview, Chainsaw tests).default.md— lighter checklist for version bumps, fixes, shared tooling, and documentation changes; applied automatically by GitHub.Since GitHub does not show a chooser for PR templates, the "Commit and Submit" section of
CONTRIBUTING_NEW_EXTENSION.mdnow links to both templates via?template=URLs.Type of change
🤖 Generated with Claude Code